-
Notifications
You must be signed in to change notification settings - Fork 2
DTSPB-4663 fix CCD Concurrency in SS #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarcusHMCTS
wants to merge
21
commits into
master
Choose a base branch
from
DTSPB-4663_Fix-CCD-concurrency-issue-in-Submit-service
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DTSPB-4663 fix CCD Concurrency in SS #1227
MarcusHMCTS
wants to merge
21
commits into
master
from
DTSPB-4663_Fix-CCD-concurrency-issue-in-Submit-service
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan Result (aat) |
Plan Result (prod) |
…bmit-service # Conflicts: # build.gradle
…ssue-in-Submit-service' into DTSPB-4663_Fix-CCD-concurrency-issue-in-Submit-service
build.gradle
Outdated
| implementation group: 'org.mapstruct', name: 'mapstruct-processor', version: versions.mapStruct | ||
| implementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: versions.jacksonDatabind | ||
| implementation group: 'net.logstash.logback', name: 'logstash-logback-encoder', version: '8.1' | ||
| implementation group: 'net.logstash.logback', name: 'logstash-logback-encoder', version: '8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downgrade? (& piTest at l173?)
| @Override | ||
| public Form saveCase(String identifier, Form form) { | ||
| log.info("Save case called"); | ||
| public Form saveCase(String identifier, LocalDateTime lastModefiedDateTime, Form form) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| public Form saveCase(String identifier, LocalDateTime lastModefiedDateTime, Form form) { | |
| public Form saveCase(String identifier, LocalDateTime lastModifiedDateTime, Form form) { |
d23bf3a to
9764d4d
Compare
…bmit-service # Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
DTSPB-4663
Change description
add the lastModifiedDateTime for concurrency issue
Testing done
Checklist